Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove prevOnRamp from multi onramp #1130

Merged
merged 13 commits into from
Jul 10, 2024
Merged

Remove prevOnRamp from multi onramp #1130

merged 13 commits into from
Jul 10, 2024

Conversation

RayXpub
Copy link
Collaborator

@RayXpub RayXpub commented Jul 2, 2024

Motivation

Missed in #985.

With the introduction of the NonceManager the prevOnRamp sequencing check isn't performed in the onramp anymore.

Solution

Remove DestChainConfig.prevOnRamp and DestChainConfigArgs.prevOnRamp.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024 •
edited
Loading

LCOV of commit cae3ae8 during Solidity Foundry #6360

Summary coverage rate:
  lines......: 98.7% (1827 of 1852 lines)
  functions..: 96.3% (340 of 353 functions)
  branches...: 90.4% (752 of 832 branches)

Files changed coverage rate: n/a

@RayXpub RayXpub marked this pull request as ready for review July 3, 2024 08:16
@RayXpub RayXpub requested review from makramkd, elatoskinas and a team as code owners July 3, 2024 08:16
@RayXpub RayXpub enabled auto-merge (squash) July 10, 2024 08:40
@RayXpub RayXpub merged commit c10a0f0 into ccip-develop Jul 10, 2024
107 checks passed
@RayXpub RayXpub deleted the chore/multi-onramp-rm-prev-onramp branch July 10, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elatoskinas elatoskinas elatoskinas approved these changes

@connorwstein connorwstein connorwstein approved these changes

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RayXpub @connorwstein @elatoskinas